Skip to content

feat(security): gate executable shared/ dotfiles + empty-profile warning - #158

Merged
LucasSantana-Dev merged 2 commits into
mainfrom
feat/145-151-profile-safety
Jul 3, 2026
Merged

feat(security): gate executable shared/ dotfiles + empty-profile warning#158
LucasSantana-Dev merged 2 commits into
mainfrom
feat/145-151-profile-safety

Conversation

@LucasSantana-Dev

@LucasSantana-Dev LucasSantana-Dev commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

Changes

  • Added DANGEROUS_SHARED_DOTFILES denylist in src/plan.ts (11 shell startup files)
  • Extended isExecutable() to gate shared/ dotfiles alongside claude/settings.json
  • Added includeDotfiles parameter throughout install/update pipeline (plan → apply → backup)
  • Updated printPlan() to display warnings for both hooks and dangerous dotfiles
  • Added --include-dotfiles flag to install and update commands in CLI
  • Added second-confirmation UX for dotfiles (mirroring hooks pattern)
  • Empty profile check in install() command (exits 1, shows warning)
  • Full test coverage: 4 tests + 1 denylist export verification

Test Plan

  • Run npm test — all 167 tests pass including new dotfiles-and-empty.test.ts
  • npm run typecheck — passes
  • npm run format:check — passes
  • Manual: sharekit install <profile-with-.zshrc> shows warning, skips file unless --include-dotfiles used

Closes #145
Closes #151

@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 2 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4f5465af-627e-4d88-b38e-bb8b8a78d1c5

📥 Commits

Reviewing files that changed from the base of the PR and between 6882448 and ce4cfd5.

📒 Files selected for processing (7)
  • README.md
  • SECURITY.md
  • src/commands.ts
  • src/index.ts
  • src/plan.ts
  • src/sharekit.ts
  • test/dotfiles-and-empty.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/145-151-profile-safety

Comment @coderabbitai help to get the list of available commands.

@LucasSantana-Dev
LucasSantana-Dev force-pushed the feat/145-151-profile-safety branch from 019083b to ce4cfd5 Compare July 3, 2026 15:14
@LucasSantana-Dev
LucasSantana-Dev merged commit 2498e5e into main Jul 3, 2026
17 checks passed
@LucasSantana-Dev
LucasSantana-Dev deleted the feat/145-151-profile-safety branch July 3, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warn when a profile contains no tool directories Executable dotfiles in shared/ bypass hook gate — silent RCE on install

1 participant

@LucasSantana-Dev